Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump theme-check-node and theme-language-server-node to latest versions #5493

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

jamesmengo
Copy link
Contributor

@jamesmengo jamesmengo commented Mar 7, 2025

WHAT are these changes introduced?

Closes https://github.com/Shopify/developer-tools-team/issues/502

Bumping the theme-tools packages.

@shopify/theme-check-node

Minor incremented 3.10.0 -> 3.11.0 (changelog)

Note

A number of changes will be in the theme-check-common package (changelog) which is treated as a dependency.

@shopify/theme-language-server-node

Minor incremented 2.9.1 -> 2.10.0 (changelog)

Note

A number of changes will be in the theme-language-server-common package (changelog) which is treated as a dependency.

How to test your changes?

theme-check

pnpm build
pnpm shopify:run theme check --path=<PATH TO THEME>

language-server

  1. Configure the language server following the instructions for one of these editors: https://github.com/Shopify/theme-tools/wiki (note: if using VS Code do not install the extension)
  2. Use the snapped version to test npm i -g @shopify/cli@0.0.0-snapshot-20250131173404
  3. Ensure any new features work (see changelog for more information)

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Update package dependencies:
- @shopify/theme-check-node from 3.10.0 to 3.11.0
- @shopify/theme-language-server-node from 2.9.1 to 2.10.0
@jamesmengo jamesmengo requested review from a team as code owners March 7, 2025 21:20
@jamesmengo jamesmengo self-assigned this Mar 7, 2025
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
76.42% (+0.01% 🔼)
9300/12169
🟡 Branches 71.65% 4559/6363
🟡 Functions 76.05% 2419/3181
🟡 Lines
76.99% (+0.02% 🔼)
8789/11416
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / app-event-watcher.ts
96.39% (-1.2% 🔻)
85.71% (-5.71% 🔻)
95.45% 100%

Test suite run success

2111 tests passing in 930 suites.

Report generated by 🧪jest coverage report action from 3011240

Copy link
Contributor

github-actions bot commented Mar 7, 2025

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

@@ -21,6 +21,8 @@ export type Scalars = {
ActionAuditID: {input: any; output: any}
/** The ID for a DocumentAttachment. */
DocumentAttachmentID: {input: any; output: any}
/** The ID for a EntitySupportingDocument. */
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appeases CI. I tested and main needs this too

@jamesmengo jamesmengo added this pull request to the merge queue Mar 11, 2025
Merged via the queue into main with commit 275033c Mar 11, 2025
30 checks passed
@jamesmengo jamesmengo deleted the jm/bump_theme_tools branch March 11, 2025 15:35
@jamesmengo jamesmengo added the #gsd:44310 LiquidDoc label Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#gsd:44310 LiquidDoc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants