Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused metafield def owner type #5492

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

aswamy
Copy link
Contributor

@aswamy aswamy commented Mar 7, 2025

WHY are these changes introduced?

Doesn't look like brand being an owner type exists anymore when fetching metafield definitions: https://shopify.dev/docs/api/admin-graphql/2025-04/queries/metafieldDefinitions#argument-ownertype

We already removed it from os-web: https://github.com/Shopify/online-store-web/pull/21978/files

WHAT is this pull request doing?

  • removed unused metafield owner type from code

How to test your changes?

n/a

Post-release steps

n/a

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@aswamy aswamy requested review from frandiox and charlespwd March 7, 2025 20:43
@aswamy aswamy requested review from a team as code owners March 7, 2025 20:43
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 76.42% 9299/12169
🟡 Branches 71.65% 4559/6363
🟡 Functions 76.05% 2419/3181
🟡 Lines
76.98% (+0.01% 🔼)
8788/11416
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / app-event-watcher.ts
96.39% (-1.2% 🔻)
88.57% (-2.86% 🔻)
95.45% 100%

Test suite run success

2111 tests passing in 930 suites.

Report generated by 🧪jest coverage report action from 1163bb1

@aswamy aswamy changed the base branch from main to jm/bump_theme_tools March 10, 2025 17:40
@aswamy aswamy changed the base branch from jm/bump_theme_tools to main March 10, 2025 20:51
@aswamy aswamy force-pushed the bugfix/remove-brand-from-metafield-fetch branch from af90016 to 1163bb1 Compare March 10, 2025 20:51
@aswamy aswamy added this pull request to the merge queue Mar 10, 2025
Merged via the queue into main with commit 4a1ab58 Mar 10, 2025
30 checks passed
@aswamy aswamy deleted the bugfix/remove-brand-from-metafield-fetch branch March 10, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants