Fix image_url on data attributes

[montalvomiguelo]

WHY are these changes introduced?

Fixes #2240

WHAT is this pull request doing?

This PR reverts the patch_body method since it's not needed anymore to fix CORS issues. Shopify/shopify-cli#2078. It will prevent replacing Shop Uris with Local Uris in data attributes.

Using the current domain addressed CORS issues per Shopify/dawn#848

How to test your changes?

pnpm shopify theme dev --path my-cool-theme

Notice that images load from CDN successfully, like in #2143

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

• n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
• Existing analytics will cater for this addition
• PR includes analytics changes to measure impact

Checklist

• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've considered possible documentation changes
• I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

[karreiro]

Thanks a lot for this PR, @montalvomiguelo!

I've tried the reproduction steps from the previous PR, and noticed that removing patch_body would reintroduce the previous issue:

Here's the steps I've followed:

• Clone the Dawn theme using git clone git@github.com:Shopify/dawn.git
• Switch to version 1.1.0 with git reset 2566749e4226818500809892259b7713808319ae --hard
• Import product data from products.csv into your store
• Run shopify theme dev
• Interact with the Classic Varsity Top and observe the browser console

Therefore, perhaps instead of removing patch_body, we could adjust the regex to make it more specific to the data-base-url attribute. This way, we could handle both Shopify/shopify-cli#1466 and #2240. What do you think?

Thanks again for this PR 🚀

[montalvomiguelo]

Hi @karreiro (:

It seems like the CORS issue persisted until Dawn v2.3.0 as reported in Shopify/dawn#548. Requesting the resources from the same origin solved the CORS issue per the work in Shopify/dawn#848. Prolly patching the data attributes is not needed anymore.

[karreiro]

Hey @montalvomiguelo,

That's accurate indeed, but partners who have to deal with outdated Dawn themes would face this issue. With that in mind, I wonder if replacing the url only on data-base-url attributes would be the ideal approach to support both scenarios. What do you think from that perspective?

Thanks again for the awesome PR :) 🚀

[montalvomiguelo]

That approach makes sense. Please let me adjust the regex to replace only data-base-url.

Thanks @karreiro (:

[karreiro]

Thank you, @montalvomiguelo! 🔥🚀