Fix an issue in shopify theme dev
that was affecting assets/fonts loading on local servers
#2110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
This PR fixes a corner case related to #2094
WHAT is this pull request doing?
When the
storefront_vanity_assets_url
flag is activated, assets URL get a different shape. So, this PR modifies the regex for the assets and fonts middlewares in theshopify theme dev
commands [1]. This change allows images to load directly from the disk when users access the local server (http://127.0.0.1:9292
), rather than pointing to the CDN URLs.[1] This flag doesn't affect theme app extensions.
How to test your changes?
storefront_vanity_assets_url
flagshopify theme init
shopify theme dev
Before

After

Post-release steps
None.
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
dev
ordeploy
have been reflected in the internal flowchart.