Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move resource strings to strings.xml #13

Closed
Sharkaboi opened this issue Jun 21, 2021 · 0 comments · Fixed by #32
Closed

Move resource strings to strings.xml #13

Sharkaboi opened this issue Jun 21, 2021 · 0 comments · Fixed by #32
Assignees
Labels
enhancement New feature or request

Comments

@Sharkaboi
Copy link
Owner

No description provided.

@Sharkaboi Sharkaboi added the enhancement New feature or request label Jun 21, 2021
@Sharkaboi Sharkaboi self-assigned this Jun 21, 2021
@Sharkaboi Sharkaboi mentioned this issue Aug 13, 2021
Merged
6 tasks
Sharkaboi added a commit that referenced this issue Aug 13, 2021
- Updated CI to run instrumentation tests and have better caching mechanism
- Upgraded project to use JDK 11
- Moved all dependency versions to ext variable set
- Bumped target and compile SDK to API 31
- Refactored `PresentationExtensions` and Enum classes to use string resources. Closes #13 
- Added instrumentation tests for `PresentationExtensions`
- Fixed small formatting issues with text
- Removed useless GraphQl calls for next episode airing time
- Handled invalid deeplinks using regex by querying default browser of phone and force opening url. Closes #30 
- Added tests for accepted deeplink regex
- Refactored `openAnimeById`, `openMangaById` and `openImageSlider` to global navigation actions
- Removed dead code
- Refactored standalone companion object classes to objects
- Extracted `UIConstants` to reuse chip styles, Image transformations, Corner radius and grid count
- Added `printStackTrace()` calls to missed catch blocks
- Cleaned up `MPAndroidChart` value formatter to use ktx functions
- Refactored `Uri.parse(url)` calls to `url.toUri()`
- Moved api constants and `MALExternalLinks` to data package
- Added `AnimeAiringStatus`, `AnimeNsfwRating`, `AnimeRating`, `MangaNsfwRating`, `MangaPublishingStatus` enums and tests
- Forced all paging data sources to work on `IO` thread
- Forced Datastore to use `IO` thread
- Refactored `MHError` to have general static error types
- Removed magic numbers to enum classes
- Fixed bug with 0 `timeToAiring` of episode returning invalid string
- Decomposed UI binding functions to smaller functions for readability
- Fixed Anime Seasonal screen not loading on navigation with season args
- Fixed Anime Ranking screen not loading on navigation with ranking args
- Fixed Manga Ranking screen not loading on navigation with ranking args
- Fixed incompatible manga ranking type slugs across manga service and manga rank service by mapping
- Refactored `OAuthRepository` to use `MHTaskState`
- Move fab explode animation to after navigation
- Rearrange `strings.xml `
- Cleaned up comments
- Updated `Readme` to use latest kotlin version and changed project info section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant