Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo in PoLidoNFT.test.ts #73

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix typo in PoLidoNFT.test.ts #73

wants to merge 1 commit into from

Conversation

massun-onibakuchi
Copy link

there are minor typo in a expected error message.

image

@massun-onibakuchi massun-onibakuchi marked this pull request as draft September 9, 2022 23:34
@massun-onibakuchi massun-onibakuchi marked this pull request as ready for review September 9, 2022 23:35
@DeFiYaco DeFiYaco requested a review from idirall22 September 14, 2022 16:41
@idirall22
Copy link
Contributor

idirall22 commented Sep 14, 2022 •
edited
Loading

@massun-onibakuchi
Thank you for your contribution
It looks like OpenZeppelin updated the error output on the last ERC721 contact, previously it was

idirall22
idirall22 approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@idirall22 idirall22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DeFiYaco DeFiYaco assigned DeFiYaco and idirall22 and unassigned DeFiYaco Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idirall22 idirall22 idirall22 approved these changes

Assignees

@idirall22 idirall22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@massun-onibakuchi @idirall22 @DeFiYaco