Merge pull request #110 from JRPoinsot/bugfix/step-binding-solution

Remove useless interface Foo in model (step binding-solution)
Sfeir · Jan 17, 2019 · 0664d29 · 0664d29
2 parents d76a933 + 8fd7d75
commit 0664d29
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 19 deletions.
diff --git a/steps/binding-solution/src/app/people.model.ts b/steps/binding-solution/src/app/people.model.ts
@@ -1,8 +1,4 @@
-interface foo {
-  bar: number;
-}
-
-export class People implements foo {
+export class People {
   id: string;
   photo: string;
   firstname: string;

diff --git a/steps/input-solution/src/app/shared/card/card.component.css b/steps/input-solution/src/app/shared/card/card.component.css
@@ -36,6 +36,8 @@ mat-card-title span {
 }
 
 mat-card-subtitle.contact-info {
+  display: flex;
+  align-items: center;
   margin-top: -7px;
   height: 20px;
 }
@@ -44,12 +46,6 @@ mat-card-title-group {
   margin-bottom: 20px;
 }
 
-.contact-info mat-icon + a {
-  top: -8px;
-  position: relative;
-  height: 18px;
-}
-
 .contact-info a:hover {
   text-decoration: underline;
 }

diff --git a/steps/input/src/app/home/home.component.css b/steps/input/src/app/home/home.component.css
@@ -47,6 +47,8 @@ mat-card-title span {
 }
 
 mat-card-subtitle.contact-info {
+  display: flex;
+  align-items: center;
   margin-top: -7px;
   height: 20px;
 }
@@ -55,12 +57,6 @@ mat-card-title-group {
   margin-bottom: 20px;
 }
 
-.contact-info mat-icon + a {
-  top: -8px;
-  position: relative;
-  height: 18px;
-}
-
 .contact-info a:hover {
   text-decoration: underline;
 }

diff --git a/steps/input/src/app/home/home.component.html b/steps/input/src/app/home/home.component.html
@@ -9,7 +9,7 @@
       </mat-card-title>
       <mat-card-subtitle>Sfeir-Paris</mat-card-subtitle>
       <mat-card-subtitle class="contact-info">
-        <mat-icon svgSrc="assets/images/icon-mail.svg"></mat-icon>
+        <mat-icon>email</mat-icon>
         <a
           href="mailto:Powers Blacks&lt;luannpowers@sfeir.com&gt;"
           title="Send an email to Powers Blacks"
@@ -18,7 +18,7 @@
         >
       </mat-card-subtitle>
       <mat-card-subtitle class="contact-info">
-        <mat-icon svgSrc="assets/images/icon-phone.svg"></mat-icon>
+        <mat-icon>phone</mat-icon>
         <a href="tel:+33688258827" title="Call Powers">+33688258827</a>
       </mat-card-subtitle>
     </mat-card-title-group>