Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timing_manager_get_time_since_sensor_done() function #429

Merged
merged 8 commits into from
Dec 19, 2024
Merged

Add timing_manager_get_time_since_sensor_done() function #429

merged 8 commits into from
Dec 19, 2024

Conversation

Known4225
Copy link
Contributor

@Known4225 Known4225 commented Dec 11, 2024 •
edited
Loading

This PR closes #427 and #428

elsevers
elsevers requested changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@elsevers elsevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Known4225. It looks like we have count_time defined twice in timing_manager.v. One as an output reg (line 63) and once as a regular reg (line 277). Need to remove the second define (line 277)

@Known4225 Known4225 changed the title User/known4225/timing manager pwm Add timing_manager_get_time_since_sensor_done() function Dec 11, 2024
@Known4225 Known4225 marked this pull request as ready for review December 11, 2024 21:03
@Known4225 Known4225 requested a review from elsevers December 16, 2024 15:43
This was linked to issues Dec 19, 2024
Add enum for PWM latching modes #427
Closed
Add ability to measure timing manager sensor data timing #428
Closed
elsevers
elsevers approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@elsevers elsevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. When we release this, we need to make sure that we indicate that the hardware project needs to be rebuilt.

@elsevers elsevers merged commit 18321d8 into develop Dec 19, 2024
1 check passed
@elsevers elsevers deleted the user/Known4225/timing-manager-pwm branch December 19, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elsevers elsevers elsevers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to measure timing manager sensor data timing Add enum for PWM latching modes
2 participants
@Known4225 @elsevers