Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply FPGA changes to fix AMDS counters #411

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Apply FPGA changes to fix AMDS counters #411

merged 2 commits into from
Aug 20, 2024

Conversation

codecubepi
Copy link
Contributor

Resolves:

See the issue conversation for full issue history.

Major Changes:

  • Only trigger AMDS interface if enabled
  • Split timeout counters into byte timeouts and data timeouts
  • Rewrite some logic for generating waiting_for_first_fe and trigger_to_fe_timer

Minor Changes

  • Rename nets in FPGA for clarity

@codecubepi
Apply FPGA changes to fix AMDS counters
1f46462 
Only trigger AMDS interface if enabled
Split timeout counters into byte timeouts and data timeouts
Rewrite some logic for generating waiting_for_first_fe and trigger_to_fe_timer
@codecubepi codecubepi added bug Something isn't working fpga Involves the FPGA Verilog code. driver Involves the drivers which interface between C firmware and hardware. labels Aug 15, 2024
@codecubepi codecubepi self-assigned this Aug 15, 2024
@codecubepi codecubepi linked an issue Aug 15, 2024 that may be closed by this pull request
New AMDS Interface not timing out correctly #393
Closed
npetersen2
npetersen2 reviewed Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@npetersen2 npetersen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks really good! One question inline to resolve.

sdk/app_cpu1/common/drv/amds.c Outdated Show resolved Hide resolved
@codecubepi codecubepi requested a review from npetersen2 August 18, 2024 17:29
This was referenced Aug 20, 2024
Merged
Merged
npetersen2
npetersen2 approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@npetersen2 npetersen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work

@codecubepi codecubepi merged commit 146936c into v1.3-staging Aug 20, 2024
1 check passed
@codecubepi codecubepi deleted the amds-timeout#393 branch August 20, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npetersen2 npetersen2 npetersen2 approved these changes

@elsevers elsevers Awaiting requested review from elsevers

Assignees

@codecubepi codecubepi

Labels
bug Something isn't working driver Involves the drivers which interface between C firmware and hardware. fpga Involves the FPGA Verilog code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New AMDS Interface not timing out correctly
2 participants
@codecubepi @npetersen2