Double @ fix #148
Merged
Double @ fix #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently being a moderator is not required to for the issue to occur. |
|
Is this actually working? @Excellify |
|
it fixed the double @ when joining a channel and loading in messages from history at least. |
AnatoleAM
approved these changes
Oct 8, 2021
AnatoleAM
added a commit
that referenced
this pull request
Mar 15, 2023
* Rename "Beta" to "Nightly" * LIVE changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the Double @ when having both 7tv and ffz installed. The historical view of messages and the first message would have a double @'User'. This would only happen in channels where you are a moderator. The reason was that the ffzMode variable was set at when the currentHandler.start() was first called. At this point the ffz hook hasn't loaded yet, so it would be set to false. Later when the first message is sendt and the componentDidUpdate() is called, the local ffzMode is still set to false, at which point it should be true.