-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding workload identity support for vn2 #67
Conversation
6d662ad
to
18d10a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in diff mode, if the difference in policy is due to the workload identity label, the user will get a list of the env vars that are added due to workload identity.
{
"skr2": {
"env_rules": [
"environment variable with rule 'AZURE_CLIENT_ID=.+' is not in the policy",
"environment variable with rule 'AZURE_TENANT_ID=.+' is not in the policy",
"environment variable with rule 'AZURE_FEDERATED_TOKEN_FILE=.+' is not in the policy",
"environment variable with rule 'AZURE_AUTHORITY_HOST=.+' is not in the policy"
]
}
}
do you think the error message should make it more clear that these env vars are linked to the workload identity label azure.workload.identity/use: "true"
That sounds like a whole feature in itself. It would need to be done for other things like privileged/unprivileged, debug mode, stdio, zero sidecars, etc. I'll put it on the list of big things to do if there's time available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adding workload identity support. There are 4 env vars and 1 mount. The mount is already added by default at
/serviceaccount
so all we needed to do was add the env vars.