forked from Azure/azure-cli-extensions
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding pylint fixes for some files #3
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevendongatmsft
approved these changes
Feb 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
SethHollandsworth
pushed a commit
that referenced
this pull request
Nov 1, 2023
…count container copy, api-version 2023-09-15-preview (Azure#6703) * init changes for 20230915-preview api * Changes to add enablePriorityBasedExecution and defaultPriorityLevel * Removed isPreview flag from CMK related properties and added key-uri to cosmosdb update operation. * Added test and test recording for priority based execution * corrected resource group name and whitespace corrections * white space corrections * Add cosmosdb copy command * Add tests * Dts/cross account copy (#3) * Deprecate old command * Add test recording for dts --------- Co-authored-by: Nitesh Vijay <niteshvijay@microsoft.com> * Fix build error * Fix Static Analysis * Use boolean type * Change help text * Update help text * Updated Vendored SDK * Updated test account name in test_cosmosdb-merge-scenario.py * Whitespace correction and added linter exclution for enable pbe * Updated linter_exclusions * Remove id part * Corrected account name in test_cosmosdb-merge-scenario.py and generated test recordings * Generated test recording for test_cosmosdb_materializedview * Add support for MI Cassandra in 2023-09-15 * Add -n for jobname * Fix breaking change * Modified setup.py and history.rst * Fix static check * Whitespace correction * Re-recorded tests * rerecorded test test_cosmosdb_sql_materializedview_scenario * removed linter exclusion for enable_priority_based_execution * Rerecorded all tests * Updated HISTORY.rst * Rerecorded tests * rerecorded test_cosmosdb_sql_materializedview_scenario * rerecorded test_cosmosdb_sql_materializedview_scenario * rerecorded tests --------- Co-authored-by: Achint Agrawal <acagrawal@microsoft.com> Co-authored-by: AdrianSibajaRetana <54075415+AdrianSibajaRetana@users.noreply.github.com> Co-authored-by: Nitesh Vijay <niteshvijay@microsoft.com> Co-authored-by: Nitesh Vijay <niteshvijay1995@gmail.com> Co-authored-by: Guanzhou <guanzhousong@microsoft.com>
SethHollandsworth
pushed a commit
that referenced
this pull request
Aug 14, 2024
* fix: --title --kind --custom-property parameters (#1) * feat: support yaml file in register command (#3) * fix: workspace parameter should not be required (#2) * style: fix lint issues (#6) * chore: update codeowner for apic-extension (#5) * feat: revert changes to min cli version (#4) * feat: resolve comments to CLI experience (#10) * feat: mark "apic api register" command as preview (#13) * feat: remove --terms-of-service parameter (#12) * feat: remove --workspace-name parameter (#11) * feat: support python 3.8 and 3.9 (#14) * feat: fix command descriptions (#17) * tests: add test cases for 'apic service' commands (#16) * feat: Use 03-01 spec from azure-rest-api-specs repo to regenerate CLI (#19) * fix: CLI errors (#20) * fix: import error when run CLI command * fix: no workspace name error when run import specification command * feat: mark some parameters as required (#21) * feat: mark --assignments parameter required for metadata commands * doc: update sample commands * feat: mark --source-resource-ids parameter as required for import-from-apim command * doc: update description for import-from-apim command * feat: bump version to 1.0.0b5 and update changelog (#18) * build: fix ci (#22) * style: fix style warnings * test:fix test cases * fix: service update command failure (#28) * doc: fix command samples (#30) * doc: update changelog per feedback (#29) * doc: remove extra spaces in register command help message (#34) * doc: update api definition and metadata command samples (#36)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pylint fixes for custom.py, security_policy.py by refactoring