-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notional trade module adjustments post audit #256
Notional trade module adjustments post audit #256
Conversation
Summary of Changes: Adjust Interface for trade methods:
Address issues raised in codearena audit:
Repo Cleanup: Remove manual deployment of wFCashFactory etc. in integration tests and related imports etc.. Instead use factory instance deployed by the notional team. |
Replaced by: IndexCoop#1 |
Code Review Processes
New Feature Review
Before submitting a pull request for new review, make sure the following is done:
README Checks
Code Checks
Broader Considerations