Fix division by zero error

SetProtocol · Apr 12, 2022 · 56bfe82 · 56bfe82
1 parent 90b0276
commit 56bfe82
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/contracts/protocol/modules/v2/PerpV2BasisTradingModule.sol b/contracts/protocol/modules/v2/PerpV2BasisTradingModule.sol
@@ -425,11 +425,16 @@ contract PerpV2BasisTradingModule is PerpV2LeverageModuleV2 {
         override(PerpV2LeverageModuleV2)
         returns (int256[] memory, int256[] memory _)
     {
-        uint256 updatedSettledFunding = _getUpdatedSettledFunding(_setToken);
+        int256 newExternalPositionUnitNetFees = 0;
 
-        int256 newExternalPositionUnit = _executePositionTrades(_setToken, _setTokenQuantity, false, true);
+        if (positions[_setToken].length > 0) {
 
-        int256 newExternalPositionUnitNetFees = _calculateNetFeesPositionUnit(_setToken, newExternalPositionUnit, updatedSettledFunding);
+            uint256 updatedSettledFunding = _getUpdatedSettledFunding(_setToken);
+
+            int256 newExternalPositionUnit = _executePositionTrades(_setToken, _setTokenQuantity, false, true);
+
+            newExternalPositionUnitNetFees = _calculateNetFeesPositionUnit(_setToken, newExternalPositionUnit, updatedSettledFunding);
+        }
 
         return _formatAdjustments(_setToken, newExternalPositionUnitNetFees);
     }