-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails to extract ID3v2 text tag if it contains a solidus ('/') #82
Comments
Created a branch here: https://github.com/ebassi/lofty-rs/tree/solidus-in-tag I copied one of the MP3 files in the test suite, and added the reproducer as a test case:
|
Serial-ATA
added a commit
that referenced
this issue
Dec 12, 2022
V2 and V3 allow for the separation of multiple values with the solidus (/) character, while in V4 the separator is null (0). This was not accounted for previously, and would break valid V4 strings ("Foo / Bar" would be split into "Foo " and " Bar"). closes #82
Serial-ATA
added a commit
that referenced
this issue
Dec 12, 2022
V2 and V3 allow for the separation of multiple values with the solidus (/) character, while in V4 the separator is null (0). This was not accounted for previously, and would break valid V4 strings ("Foo / Bar" would be split into "Foo " and " Bar"). closes #82
Thanks! |
Thanks for the super-quick fix, it's much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reproducer
Create an MP3 file with an ID3v2 tag, set the title tag to
Foo / title
, and save it assolidus_in_tag.mp3
.Summary
If an ID3v2 text tag contains a solidus (
/
) then whatever follows the character gets dropped; e.g. a title tag set toFoo / title
is returned asFoo
.Expected behavior
The reproducer should pass; the title tag should return
Foo / title
.Assets
No response
The text was updated successfully, but these errors were encountered: