Please review topic branch 'users/brigadir/ticket.39-39' #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 20, 2016 12:45
FPS now always shown at the left top corner of the graph window regardless of the window scrolling. FPS statistic is rendered on top of the graph elements. Therefore FPS text may overlap the graph. And this may cause FPS text to become unreadable. It would be nice to have some solid color background under FPS text. But because this text is rendered via `D2D1::IDWriteTextFormat` interface I can't determine exact text bounds. And I can't use `D2D1::IDWriteTextLayout` instead of `D2D1::IDWriteTextFormat` because FPS statistics must be drawn quickly, so FPS text rendering will not interfere graph rendering (time). Resolves: #39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed tickets #38 and #39
☝️ For reasons I had emailed you recently (yesterday I believe) I did not push this changes onto the Bitbucket! 👊
💣 
🔫 