Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non code tweaks #15

Merged
merged 3 commits into from
Mar 27, 2020
Merged

Non code tweaks #15

merged 3 commits into from
Mar 27, 2020

Conversation

elliott-imhoff
Copy link
Member

Some small updates to non-code files

What?

  • Added configuration module to auto-generated documentation
  • Updated README with documentation generation instructions
  • Travis installs via pipenv install --dev --deploy
  • Updated PR template

Why?

These kinds of things really bug me if they aren't taken care of.

PR Checklist

  • Merged latest master
  • Updated version number

Breaking Changes

Nosiribubski

@elliott-imhoff elliott-imhoff requested review from jdalt and Olson3R March 27, 2020 14:25
@@ -3,7 +3,7 @@ python: 3.7

install:
- pip install pipenv
- pipenv install --dev
- pipenv install --dev --deploy
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer have the --deploy flag on Travis installs to make Travis fail if ever the Pipfile and Pipfile.lock are out of sync.

@@ -1,6 +1,7 @@
# <Title_Here>
## What?
## Why?
## PR Checklist
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People have been putting a heading here, which I like. Might as well automatically put it there. Let me know if you prefer the "QA Strategy" heading instead.

the repo, run
This library is documented using Sphinx. To generate documentation, make sure all **dev**
dependencies are installed (e.g. you've installed via ``pip install -e .[dev]``). Within
the *docs/* subdirectory, run:
Copy link
Member Author

@elliott-imhoff elliott-imhoff Mar 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #14. We should use Github Pages to automatically generate and publish documentation. I've always wanted to do it, but it's only allowed for public repos, so this might be my one chance.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we get Github Pages automatically running?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't be too hard. There are tons of tutorials online

the repo, run
This library is documented using Sphinx. To generate documentation, make sure all **dev**
dependencies are installed (e.g. you've installed via ``pip install -e .[dev]``). Within
the *docs/* subdirectory, run:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we get Github Pages automatically running?

@elliott-imhoff elliott-imhoff merged commit 119533d into master Mar 27, 2020
@elliott-imhoff elliott-imhoff deleted the non-code-tweaks branch March 27, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants