Fixes #1870, port hash function into Satellite #1913
Conversation
There was a problem hiding this comment.
The changes to the auth service are good, but let's undo the ones to src/backend and test/, since that code doesn't use microservices.
Our goal is to replace the current backend (i.e., delete it) with the microservices once they are done, similar to what we did with next and gatsby.
package.json
Outdated
| @@ -53,6 +53,7 @@ | |||
| "dependencies": { | |||
| "@elastic/elasticsearch": "7.11.0", | |||
| "@elastic/elasticsearch-mock": "0.3.0", | |||
| "@senecacdot/satellite": "1.8.0", | |||
There was a problem hiding this comment.
I don't want to use Satellite in the monolithic back-end, only in the microservices. Let's undo this.
src/api/auth/src/admin.js
Outdated
| @@ -1,5 +1,5 @@ | |||
| const User = require('./user'); | |||
| const hash = require('./hash'); | |||
| const satellite = require('@senecacdot/satellite'); | |||
There was a problem hiding this comment.
Just pull in the function you need.
const { hash } = require('@senecacdot/satellite');
src/backend/data/admin.js
Outdated
| @@ -1,6 +1,6 @@ | |||
| const Feed = require('./feed'); | |||
| const User = require('./user'); | |||
| const hash = require('./hash'); | |||
| const satellite = require('@senecacdot/satellite'); | |||
There was a problem hiding this comment.
No to this change (only in microservices).
Just did, and I rebased, so it should be good to go. Are there any other modules that we could port onto Satellite? |
Issue This PR Addresses
Fixes #1870
Type of Change
Ported Hash Functions from Satellite onto Telescope, removed
hash.jsDescription
Discussed in #1870 , We ended up porting our hash function onto Satellite, and removed
hash.json both/apiand/backendChecklist