-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Dependabot config for Docker, GitHub Actions, and more npm packages #1878
Conversation
@birtony #1778 is being put on hold for now until npm workspaces gets updated later on this year so that's out of the question. Keep in mind that you'd also need to check other microservices' Dockerfiles and package.jsons such as the Posts service (#1735), User service (#1642), and Post parsing service (#1736). That would no doubt increase the number of PRs dependabot will do each week alone. It might be in our best interest to relook exactly what it needs to check so we don't end up flooded again |
I think we can try this and see how it goes. Right now we only have GitHub Actions and Vercel to worry about. As long as we don't overload those, we're good. We can turn this on and see what happens. But let's not do it on a Friday again please. When this gets merged, I want some people staying near their machines to step in if it needs adjustments. As long as we have that, I'm OK to experiment with it. |
Added Dependabot config for GitHub Actions Added configurations for more npm and docker files Split checks to different weekdays/times
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is doable since the old dependabot PRs can usually get reviewed and merged within a day
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the scattered day approach.
Issue This PR Addresses
Fixes #1799
Type of Change
Description
Added Dependabot configurations for Dockerfiles, GitHub Actions, and more package.json files in our repository. Tested on my forked repository, you can see that all of them appeared under https://github.com/birtony/telescope/network/updates
![image](https://user-images.githubusercontent.com/33902374/110174056-83ec4800-7dcd-11eb-8f1b-c7498cd283ea.png)
Warning
Even though this PR limits each package ecosystem to only 1 open PR at a time and sets Dependabot to make checks on each once a week, it can potentially lead to Dependabot creating 9 PRs at once. Although with automatic rebases turned off, that would mean 9 CI runs/preview deployments, I am not sure if it can exhaust any quotas of ours. I am also not sure if we can limit Dependabot in any other way unless we switch to using npm workspaces (#1778). @humphd, please, advise.
Checklist