Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dependabot config for Docker, GitHub Actions, and more npm packages #1878

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

birtony
Copy link
Contributor

@birtony birtony commented Mar 5, 2021

Issue This PR Addresses

Fixes #1799

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Added Dependabot configurations for Dockerfiles, GitHub Actions, and more package.json files in our repository. Tested on my forked repository, you can see that all of them appeared under https://github.com/birtony/telescope/network/updates
image

Warning

Even though this PR limits each package ecosystem to only 1 open PR at a time and sets Dependabot to make checks on each once a week, it can potentially lead to Dependabot creating 9 PRs at once. Although with automatic rebases turned off, that would mean 9 CI runs/preview deployments, I am not sure if it can exhaust any quotas of ours. I am also not sure if we can limit Dependabot in any other way unless we switch to using npm workspaces (#1778). @humphd, please, advise.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@birtony birtony added type: enhancement New feature or request area: docker developer experience Helping the Developer Experience area: tools Priority: Medium dependencies Pull requests that update a dependency file labels Mar 5, 2021
@birtony birtony added this to the 1.8 Release milestone Mar 5, 2021
@birtony birtony self-assigned this Mar 5, 2021
@birtony birtony changed the title Added Depednabot config for Docker Added Depednabot config for Docker, GitHub Actions, and more npm packages Mar 5, 2021
@HyperTHD
Copy link
Contributor

HyperTHD commented Mar 6, 2021

@birtony #1778 is being put on hold for now until npm workspaces gets updated later on this year so that's out of the question.

Keep in mind that you'd also need to check other microservices' Dockerfiles and package.jsons such as the Posts service (#1735), User service (#1642), and Post parsing service (#1736). That would no doubt increase the number of PRs dependabot will do each week alone. It might be in our best interest to relook exactly what it needs to check so we don't end up flooded again

@humphd
Copy link
Contributor

humphd commented Mar 6, 2021

I think we can try this and see how it goes. Right now we only have GitHub Actions and Vercel to worry about. As long as we don't overload those, we're good. We can turn this on and see what happens.

But let's not do it on a Friday again please. When this gets merged, I want some people staying near their machines to step in if it needs adjustments.

As long as we have that, I'm OK to experiment with it.

humphd
humphd previously approved these changes Mar 6, 2021
yuanLeeMidori
yuanLeeMidori previously approved these changes Mar 6, 2021
@birtony
Copy link
Contributor Author

birtony commented Mar 7, 2021

@HyperTHD @humphd I just got an idea. Why don't we configure each package to be checked on different weekdays/times. That way they won't create 9 PRs at once, but rather add them incrementally over time. As far as we keep them reviewing open PRs, they should not pile up.

Added Dependabot config for GitHub Actions

Added configurations for more npm and docker files

Split checks to different weekdays/times
Copy link
Contributor

@yuanLeeMidori yuanLeeMidori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is doable since the old dependabot PRs can usually get reviewed and merged within a day

@cindyorangis cindyorangis changed the title Added Depednabot config for Docker, GitHub Actions, and more npm packages Added Dependabot config for Docker, GitHub Actions, and more npm packages Mar 7, 2021
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the scattered day approach.

@birtony birtony merged commit 34d0e77 into master Mar 8, 2021
@birtony birtony deleted the issue1799 branch March 8, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tools dependencies Pull requests that update a dependency file developer experience Helping the Developer Experience type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add configuration to track docker file and GitHub Actions to Dependabot
4 participants