Lingo 3.2.3 improvements #78
Conversation
…rching for specific search terms in the backend
…ped version to v5
| @@ -45,6 +45,8 @@ public function testCanConstruct() { | |||
|
|
|||
| public function testGetTermsForSingleTermWithDefinitionOnNonCachedResult() { | |||
|
|
|||
| $this->markTestSkipped( 'Needs to be fixed with the new version of SG' ); | |||
There was a problem hiding this comment.
Why do we have to wait for the next release before the tests can be fixed? If there are specific dependencies we should name them.
There was a problem hiding this comment.
You are right, but refactoring the tests is a whole other process. I resolved the merge conflicts anyways, the test cases should be revised at one point anyways.
|
@YOUR1 many thanks for your PR! Is this still work in progress? If yes, please set it to draft so that others know that it is not yet ready to review. At the moment, Git reports "This branch has conflicts that must be resolved" |
|
ping @YOUR1 |
Thanks again for the headsup. I will take a look at this today! |
|
The failed tests are not part of my change, it seems something is wrong within the build pipeline itself. |
|
@paladox do you have a moment to look into the CI issue with "Composer\Plugin\PluginBlockedException"? |
|
That change has been merged. This pull should be rebased and tests should pass. |
# Conflicts: # src/Cache/CacheInvalidator.php # src/Cache/GlossaryCache.php # src/LingoBackendAdapter.php # src/Maintenance/GlossaryCacheRebuilder.php # src/PropertyRegistrationHelper.php # src/SemanticDataComparator.php # tests/phpunit/Integration/MwDBSQLStoreIntegrationTest.php # tests/phpunit/Unit/Cache/CacheInvalidatorTest.php # tests/phpunit/Unit/Cache/ElementsCacheBuilderTest.php # tests/phpunit/Unit/ConfigurationIntegrityTest.php # tests/phpunit/Unit/LingoBackendAdapterTest.php # tests/phpunit/Unit/PropertyRegistrationHelperTest.php # tests/phpunit/Unit/SemanticDataComparatorTest.php
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #78 +/- ##
============================================
+ Coverage 73.04% 75.86% +2.81%
- Complexity 93 97 +4
============================================
Files 8 8
Lines 371 377 +6
============================================
+ Hits 271 286 +15
+ Misses 100 91 -9 ☔ View full report in Codecov by Sentry. |
|
So, the CI pipelines working again (including codestyle). What a mess. I don't agree with the codecov tho. |
|
@gesinn-it-gea what do you think about this? |
Removing SMW req
|
Seems a little bit that we're going in circles here. I'll see if I can fix the tests, but it feels a bit strange that we are removing the SMW dependency |
|
Btw; @paladox, in the Makefile it declares the SMW 4.x version, shouldn't that automatically be loaded when running 'make'? |
|
There has been a discussion regarding SMW dependencies in SMW extensions here: SemanticMediaWiki/SemanticResultFormats#787 |
|
There you go @gesinn-it-gea :] |
This PR addresses or contains:
This PR includes: