Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 4.0 release #61

Merged
merged 3 commits into from
Jul 9, 2021
Merged

Make 4.0 release #61

merged 3 commits into from
Jul 9, 2021

Conversation

kghbln
Copy link
Member

@kghbln kghbln commented Jul 8, 2021

This PR is made in reference to: #54

This PR addresses or contains:

  • Updated README
  • Added notes about the release
  • Bumps version
  • Tidies and updates

This PR includes:

  • Update of RELEASE-NOTES.md
  • Tests (unit/integration)
  • CI build passed

Fixes: #54

@kghbln kghbln requested a review from hexmode July 8, 2021 22:16
@kghbln
Copy link
Member Author

kghbln commented Jul 8, 2021

@hexmode @krabina As promised the pull for the next field tested release

@kghbln
Copy link
Member Author

kghbln commented Jul 8, 2021

Since it was field tested by you I do not give a d... about the automated tests failing. I assume this will be rectified in consecutive pulls which potentially lead to new releases

@krabina
Copy link
Contributor

krabina commented Jul 9, 2021

I can confirm that it is working now, also the NOGLOSSARY
You should update the README thought, because you need to invoke Lingo in LocalSettings.php manually (right before Semantic Glossary) and upgrade to the latest version of Lingo...

@kghbln
Copy link
Member Author

kghbln commented Jul 9, 2021

@krabina Thanks for the note. I will modify. About LIngo. We are talking about 3.1+ here?

@krabina
Copy link
Contributor

krabina commented Jul 9, 2021

yes I think so. I am on master, wich is 3.1.2 (257b1f7) 07:23, 28 June 2021, but it was working before as well (which probably was 3.1.1)

@kghbln
Copy link
Member Author

kghbln commented Jul 9, 2021

Thanks for the info. I assume that 3.1 works here. Apart form that, there is no tagged version 3.1.2 but this does not surprise. Edit: Ah, master. :)

@kghbln kghbln merged commit 264f809 into master Jul 9, 2021
@kghbln kghbln deleted the sg40 branch July 9, 2021 13:26
@kghbln
Copy link
Member Author

kghbln commented Jul 9, 2021

@krabina Lucky you. Broken on https://sandbox.semantic-mediawiki.org/wiki/Glossary_test :( Also tested Vector.

@krabina
Copy link
Contributor

krabina commented Jul 9, 2021

Try the latest master of Lingo. And how can it be on PHP 7.2 when for MW 1.35 PHP 7.3 is required?

@kghbln
Copy link
Member Author

kghbln commented Jul 9, 2021

This does not help either. I am on a MW 1.35 release candidate. PHP 7.3 requirement was added later. Since I cannot upgrade the server I am stuck.

@kghbln
Copy link
Member Author

kghbln commented Jul 9, 2021

I will test with another wiki once I get to it. I am not getting any fatals or errors in console. This alone is already a step forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SG 4.0 release
2 participants