docs(Icon): add icon search #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effe549 to
949ed07
Compare
Current coverage is 100% (diff: 100%)@@ master #977 diff @@
====================================
Files 137 137
Lines 2284 2286 +2
Methods 0 0
Messages 0 0
Branches 0 0
====================================
+ Hits 2284 2286 +2
Misses 0 0
Partials 0 0
|
7dd2b5d to
83db94f
Compare
levithomason
commented
Dec 3, 2016
| @@ -153,7 +153,7 @@ class Menu extends Component { | |||
| const { activeIndex } = this.state | |||
|
|
|||
| return _.map(items, (item, index) => { | |||
| return createShorthand(MenuItem, val => ({ content: val }), item, { | |||
| return createShorthand(MenuItem, val => ({ content: val, name: val }), item, { | |||
There was a problem hiding this comment.
When using shorthand items as an array of strings, the strings were not passed to the name prop of the menu item, so the callback name was undefined. I've added the literal shorthand values to the name prop so the callbacks contain the name.
83db94f to
b03f5f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finding icons can be a pain. The current icon set examples are far too large to be of any use with the code editor provided. You need to scroll up and down for pages to make changes and see your results. Users probably also have no idea that there are other examples at the bottom of that massive page.
This PR removes the code editor icon set examples and replaces them with an icon search. It moves the other examples to an "Examples" tab for clarity.
Search Features
Demo