Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Button): Prevent click on disabled button #930

Merged
merged 1 commit into from
Nov 23, 2016

Conversation

jeffcarbs
Copy link
Member

@jeffcarbs jeffcarbs commented Nov 23, 2016

Fixes #929

  • Prevent clicks on a disabled button (both mouse clicks and "clicks" via focus + pressing enter). Also called preventDefault on the click event when the button is disabled to prevent form submission (if within a form) or link following (if an a).
  • Pass back props to the onClick and documented the onClick prop as spec'd in RFC: all event handlers should callback with (event, data) #623 (comment)

@codecov-io
Copy link

Current coverage is 100% (diff: 100%)

No coverage report found for master at 52b36c7.

Powered by Codecov. Last update 52b36c7...6aa5453

@levithomason
Copy link
Member

Looks good, thanks!

@levithomason levithomason merged commit 3d11955 into master Nov 23, 2016
@levithomason levithomason deleted the feature/disabled-button branch November 23, 2016 17:44
Arthelon pushed a commit to Arthelon/Semantic-UI-React that referenced this pull request Nov 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants