Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Input): pass all handlers to the html input #886

Merged
merged 1 commit into from
Nov 17, 2016
Merged

fix(Input): pass all handlers to the html input #886

merged 1 commit into from
Nov 17, 2016

Conversation

levithomason
Copy link
Member

@levithomason levithomason commented Nov 17, 2016 •
edited
Loading

Fixes #884

We currently pass onChange to the HTML input element but others are spread on the root node as unhandled props. This caused inconsistent behavior in the event object since the onChange receives the event before the root node.

This PR passes all event handlers to the HTML input, resolving any issues with event manipulation, such as e.preventDefault().

@levithomason levithomason mentioned this pull request Nov 17, 2016
Closed
@levithomason levithomason force-pushed the fix/input-event-handlers branch from 2b9824c to 8519b49 Compare November 17, 2016 17:47
@levithomason levithomason merged commit 9950950 into master Nov 17, 2016
@levithomason levithomason deleted the fix/input-event-handlers branch November 17, 2016 18:07
@levithomason
Copy link
Member Author

Released in semantic-ui-react@0.61.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support onKeyDown in Input
1 participant
@levithomason