Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(docs): improve doc bundle and load experience #865

Merged
merged 2 commits into from
Nov 16, 2016

Conversation

levithomason
Copy link
Member

@levithomason levithomason commented Nov 16, 2016

Fixes #765

This PR removes improves the doc bundle size and rebuild time. I've moved most scripts to CDNs so they can be loaded in parallel and cached longer client side. I've also added an instantly loaded dimmer to entertain during any wait period.

app.js vendor.js modules build rebuild
Before 3 Mb 1,110 Kb 2620 ~14s ~2s
After 3 Mb 2,018 Kb 2455 ~10s ~1s

@codecov-io
Copy link

codecov-io commented Nov 16, 2016

Current coverage is 100% (diff: 100%)

Merging #865 into master will not change coverage

@@           master   #865   diff @@
====================================
  Files         137    137          
  Lines        2254   2254          
  Methods         0      0          
  Messages        0      0          
  Branches        0      0          
====================================
  Hits         2254   2254          
  Misses          0      0          
  Partials        0      0          

Powered by Codecov. Last update aa8d409...d7fa727

@levithomason levithomason merged commit 330d006 into master Nov 16, 2016
@levithomason levithomason deleted the perf/doc-bundle-size branch November 16, 2016 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants