Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Input): use e.target.value in onChange data.value #853

Merged
merged 1 commit into from
Nov 14, 2016

Conversation

levithomason
Copy link
Member

@levithomason levithomason commented Nov 14, 2016

#846 added props as the second callback param to Input onChange, however, the value in the second param should be usable in a controlled component pattern. This means the value in the second parameter should be the event target value and not the prop value, otherwise, when used in a controlled component pattern, the value would never update.

This PR updates the value in the second param to an Input's onChange to reflect the event target value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant