fix(Input): use e.target.value in onChange data.value #853
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#846 added
props
as the second callback param to InputonChange
, however, thevalue
in the second param should be usable in a controlled component pattern. This means thevalue
in the second parameter should be the event target value and not the prop value, otherwise, when used in a controlled component pattern, the value would never update.This PR updates the
value
in the second param to an Input'sonChange
to reflect the event target value.