Checkbox plugin #80
Merged
Checkbox plugin #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c638435 to
7e53f43
Compare
326d768 to
e71a671
Compare
| @@ -1,6 +1,3 @@ | |||
| { | |||
| "extends": "ta-webapp", | |||
| "env": { | |||
| "node": true | |||
| } | |||
There was a problem hiding this comment.
Cruft, this is handled by the ta-webapp config now.
| return ( | ||
| <Checkbox defaultChecked label='This checkbox comes prechecked' /> | ||
| ); | ||
| }; |
There was a problem hiding this comment.
To check a checkbox, just set the React defaultChecked prop. This works because props are spread where they should be.
|
|
||
| const checkboxProps = _.clone(this.props); | ||
| delete checkboxProps.className; | ||
| const props = getUnhandledProps(this); |
There was a problem hiding this comment.
I hadn't seen this utility before! NEATO!
There was a problem hiding this comment.
This is a newer util. Gets all props not defined in propTypes nor defaultProps.
|
🍂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets precedence for how we deal with Semantic UI jQuery plugins.
Fixes #72