Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ComponentDoc): show props by default #762

Merged
merged 1 commit into from
Oct 28, 2016
Merged

Conversation

levithomason
Copy link
Member

@levithomason levithomason commented Oct 28, 2016

The current docs hide the props behind a little gray toggle switch in the header of every component doc page. The default state is to collapse the prop table. We've had several users not know where to find props. It seems it is too subdued.

This PR makes sets default prop table state to open. As before, the prop table state (open/closed) persists across route changes. If you do not want to see props and you toggle them closed, then they will remain closed for your entire browser session.

@codecov-io
Copy link

Current coverage is 99.48% (diff: 100%)

Merging #762 into master will not change coverage

@@             master       #762   diff @@
==========================================
  Files           134        134          
  Lines          2154       2154          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           2143       2143          
  Misses           11         11          
  Partials          0          0          

Powered by Codecov. Last update 0aed385...5821627

@levithomason levithomason merged commit 00e856a into master Oct 28, 2016
@levithomason levithomason deleted the docs/show-props branch October 28, 2016 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants