fix(Modal): Only set position when modal is open #721
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #712
The modal has code that continuously calculates its position to:
This was being called on component mount, which doesn't make sense since the modal itself may not actually be visible. This updates the the
setPosition
to start when thePortal
gets mounted (the modal becomes visible) and stop when thePortal
unmounts (the modal is hidden).This should:
mountNode
until the page has been fully rendered. This (I think) should fix Modal relies on document as default renderNode, breaks SSR #712 since themountNode
defaults todocument.body
which isn't present server-side.