feat(Search|Dropdown): Improve arrow navigation #701
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves arrow navigation in both the dropdown and search menus.
Previously
When pressing "arrow-down" to move through results once an item was past the bottom the menu's scrollTop would move to that item's scrollTop, which was kinda jarring. It was almost as if you were moving to the next "page" of items, which is pretty non-standard:
After
When an item is past the bottom, the menu adjusts so that the bottom of the menu is at the item's bottom:
This also fixes the specs that were testing this functionality - they weren't actually testing anything 😐