fix(Dropdown): blur virtual DOM with real DOM #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #692
All event handlers are added/removed based on the virtual DOM events. A recent PR blurred the Dropdown node on close (#628) to prevent a re-opening bug on switching browser tabs. It did not also blur the virtual DOM. This circumvented the Dropdown's virtual DOM onBlur event which removes the
openOnSpacelistener. This created a bug where a Dropdown without focus opens when pressing space anywhere on the page.This PR blurs the virtual DOM along side blurring the real DOM. It also adds missing tests for these areas.
Lastly, this PR removes logic and tests for the now unreachable state of "closed and focused". The Dropdown is now blurred on close so it is impossible to enter this state and those tests were failing.