fix(Label): fix shorthand create method #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100% (diff: 100%)@@ master #644 diff @@
====================================
Files 119 119
Lines 1890 1890
Methods 0 0
Messages 0 0
Branches 0 0
====================================
Hits 1890 1890
Misses 0 0
Partials 0 0
|
|
Still working on figuring out what is going on with PR build statuses. This PR is passing and fully covered: Tests passed: https://circleci.com/gh/Semantic-Org/Semantic-UI-React/56 |
labeled usages|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 issues:
labeledButton usages in the docsLabel.createreturned undefinedHeads up, we cannot put a
static create = createShorthandFactory()call in a class, as was the Label. TheLabelclass is not yet defined, so the factory returnsundefined.I've updated the factories to throw if the Component is not a string or function. I've also added tests for this.