fix(Checkbox): no onChange/onClick when disabled

[sprmn]

Check if disabled before calling onChange function.

Fixes #600

[layershifter]

@sprmn Thanks for PR!

Your addition failed because you don't spreaded disabled, you need do this:

- const { onChange, onClick, name, value } = this.props
+ const { onChange, onClick, disabled, name, value } = this.props

Could you add a test-case for this? In Checkbox-test.js in describe('onChange'', () => {

it('omitted when has disabled prop', () => {
  const click = () => mount(<Checkbox disabled onChange={spy} />).simulate('click')
  expect(click).to.not.throw()
})

[sprmn]

Oops, thought that it was already spread, but that was in the canToggle function, my bad.
I'll fix it and add a test case.

[layershifter]

You can run tests with npm run test:watch and linter npm run lint:fix 👍

[codecov-io]

Current coverage is 100% (diff: 100%)

Merging #601 into master will not change coverage

@@           master   #601   diff @@
====================================
  Files         119    119          
  Lines        1915   1915          
  Methods         0      0          
  Messages        0      0          
  Branches        0      0          
====================================
  Hits         1915   1915          
  Misses          0      0          
  Partials        0      0          

Powered by Codecov. Last update 6c72147...483862e

[jeffcarbs]

A few things:

• There are props for disabled and readOnly but they're not being applied as classes. They should add the disabled and read-only classes respectively. Let's also add specs for those:

  common.propKeyOnlyToClassName(Checkbox, 'disabled')
  common.propKeyOnlyToClassName(Checkbox, 'readOnly', {
    className: 'read-only',
  })

• There's already a method to determine if the checkbox can be toggled - canToggle. We're currently only using it to determine if we should try to update the checked state, but I think we should also use that to prevent the click/change handlers. So:

-    if (onClick) onClick(e, { name, value, checked: !!checked })
-    if (onChange) onChange(e, { name, value, checked: !checked })
-
     if (this.canToggle()) {
+      if (onClick) onClick(e, { name, value, checked: !!checked })
+      if (onChange) onChange(e, { name, value, checked: !checked })
+
       this.trySetState({ checked: !checked })
     }

[sprmn]

Even better! Should be fixed now.

[jeffcarbs]

Checked this out locally and works as expected, 👍 🚢 💨

[jeffcarbs]

@levithomason - this is ready to merge when you are 👍

[levithomason]

Thanks for taking care of this guys! Released in semantic-ui-react@0.54.1.