fix(Button): render labeled as a <button>
#597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix switch button to div
Current coverage is 100% (diff: 100%)@@ master #597 diff @@
====================================
Files 119 119
Lines 1915 1915
Methods 0 0
Messages 0 0
Branches 0 0
====================================
Hits 1915 1915
Misses 0 0
Partials 0 0
|
levithomason
requested changes
Oct 3, 2016
|
Should work in production this trick fixed the problem. |
levithomason
requested changes
Oct 3, 2016
| wrapper.should.have.tagName('button') | ||
| wrapper.should.have.className('labeled') | ||
| wrapper.should.have.exactly(1).descendants('Icon') | ||
| }) |
There was a problem hiding this comment.
Thanks for the test, let's simplify it a bit. It is best to write tests that are as minimal as possible and assert one thing. This makes them stronger and more maintainable.
In this case, most of the assertions made here are covered by other existing tests, all we should need to assert is that a labeled button renders a button element:
it('renders as a button', () => {
shallow(<Button labeled />)
.should.have.tagName('button')
})labeled as a <button>
levithomason
approved these changes
Oct 3, 2016
|
One linter issue:
|
|
Also, if the description of this PR were updated slightly, it will auto close the related issue on merge: https://github.com/blog/1506-closing-issues-via-pull-requests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix switch button to div
#596