Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): editable examples #566

Merged
merged 14 commits into from
Sep 30, 2016
Merged

feat(docs): editable examples #566

merged 14 commits into from
Sep 30, 2016

Conversation

levithomason
Copy link
Member

@levithomason levithomason commented Sep 29, 2016

Done

  • show JSX and HTML on load for direct anchor links
  • allow editing JSX
  • show errors
  • update rendered HTML with rendered component
  • debounce errors/render for better performance
  • transform import/export statements to work in the browser

TODO

  • Icon examples relied on props being passed through the component example. That no longer works. Fix icon examples.

http://g.recordit.co/9We8CrvDIV.gif

@levithomason levithomason changed the title feat(ComponentExample): begin editable examples feat(docs): editable examples Sep 29, 2016
@codecov-io
Copy link

codecov-io commented Sep 29, 2016

Current coverage is 99.49% (diff: 100%)

Merging #566 into master will not change coverage

@@             master       #566   diff @@
==========================================
  Files           112        112          
  Lines          1767       1767          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1758       1758          
  Misses            9          9          
  Partials          0          0          

Powered by Codecov. Last update dceef53...df08a45

@levithomason levithomason merged commit 56f88f7 into master Sep 30, 2016
@levithomason levithomason deleted the docs/editable-examples branch September 30, 2016 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants