chore(build): add browser build #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45eac5a to
1456fd0
Compare
Current coverage is 98.74% (diff: 100%)@@ master #518 diff @@
==========================================
Files 106 107 +1
Lines 1753 1754 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1731 1732 +1
Misses 22 22
Partials 0 0
|
levithomason
commented
Sep 20, 2016
| @@ -6,7 +6,7 @@ if (process.env.NODE_ENV !== 'production' && process.env.NODE_ENV !== 'test') { | |||
| // Safari private mode throws when writing to localStorage | |||
| // https://github.com/TechnologyAdvice/stardust/issues/332 | |||
| try { | |||
| if (typeof localStorage === 'object') localStorage.debug = localStorage.debug || 'stardust:*' | |||
| if (typeof localStorage === 'object') localStorage.debug = localStorage.debug || null | |||
There was a problem hiding this comment.
Made debug info opt-in as it is extremely noisy.
levithomason
commented
Sep 20, 2016
| @@ -8,6 +8,9 @@ | |||
| "lodash" | |||
| ], | |||
| "env": { | |||
| "browser": { | |||
| "plugins": ["add-module-exports"] | |||
| }, | |||
There was a problem hiding this comment.
We need module exports for the window object, prevents us from having to do stardust.default.Button.
levithomason
commented
Sep 20, 2016
| task('webpack-docs', (cb) => { | ||
| const webpackConfig = require('../../webpack.config') | ||
| const compiler = webpack(webpackConfig) | ||
| task('build:docs:dll', (cb) => { |
There was a problem hiding this comment.
I properly named the gulp tasks.
levithomason
commented
Sep 20, 2016
| "docs": "gulp docs", | ||
| "build": "npm run build:commonjs && npm run build:docs", | ||
| "prebuild:commonjs": "rimraf dist/commonjs", | ||
| "build:commonjs": "babel src -d dist/commonjs", |
There was a problem hiding this comment.
I split up the commonjs (npm) build from the umd (browser) build.
1456fd0 to
35292e0
Compare
levithomason
commented
Sep 20, 2016
| ...elements, | ||
| ...modules, | ||
| ...views, | ||
| version, |
There was a problem hiding this comment.
I've added the package version to the exported object. Available in the browser and in the commonjs build.
27d0c85 to
fa24d19
Compare
fa24d19 to
2868fcb
Compare
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a browser build. It will be used in online editors (jsFiddle, Codepen, etc.) for bug reports. We may also find use for this build in v2 of the doc site.