fix(customPropTypes): show all errors if some() fails #473
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
some()
validator requires at least one prop type validator to pass. Currently, if they all fail we show only the first validator error message.This is not helpful as the first error may not be applicable to the usage, perhaps it is the 3rd error that should be resolved for a particular usage. This PR updates the error message to include all errors messages so the user can correct at least one. Resulting in
some()
validator passing: