feat(Dropdown): close on blur #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 98.31% (diff: 100%)@@ master #467 diff @@
==========================================
Files 98 98
Lines 1421 1426 +5
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1397 1402 +5
Misses 24 24
Partials 0 0
|
| @@ -994,6 +1011,7 @@ describe('Dropdown Component', () => { | |||
| .simulate('focus') | |||
|
|
|||
| domEvent.keyDown(document, { key: 'ArrowDown' }) | |||
| domEvent.keyDown(document, { key: 'ArrowDown' }) | |||
There was a problem hiding this comment.
Looks like a duplicate down arrow here.
There was a problem hiding this comment.
Ah, never mind, I see the close on blur requires another arrow to open.
There was a problem hiding this comment.
There is a comment on 1008 that we should update or remove:
// blur, focus, move item selection downSince we are now opening after the focus.
|
Thanks for the solid work. I've left a few requests for adding/updating comments only. Then we're good to merge. |
|
@levithomason Changed the comments to your requests. |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the TODO that the Dropdown didn't close on blur.
I did not yet make it open on focus (other TODO), since I wanted to ask for your comments on this.
In my opinion that behavior is not always wanted, but it is how vanilla SUI works right now.