Dropdown: Pass 'options' objects as props to Dropdown.Item #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 95.15% (diff: 100%)@@ master #418 diff @@
==========================================
Files 91 91
Lines 1177 1177
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1120 1120
Misses 57 57
Partials 0 0
|
| value: PropTypes.oneOfType([ | ||
| PropTypes.string, | ||
| PropTypes.number, | ||
| ]).isRequired, |
There was a problem hiding this comment.
Note: This isRequired got dropped in this change.
On the one hand, PropTypes.arrayOf(PropTypes.shape(DropdownItem.propTypes)) is much DRYer and less brittle.
On the other, there's a slight difference in terms of what props are required that we're now ignoring.
Open to suggestions here.
There was a problem hiding this comment.
Seems reasonable for now. The text/value props can't reliably be required at the DropdownItem level as there is no guarantee they are being used in a selection Dropdown.
Previously only 'text' and 'value' were being passed to <Dropdown.Item> for each object in `options`. This makes it so the entire objects are passed as props.
260d069 to
46cea61
Compare
|
Updated based on comments 👍 |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When specifying options on a dropdown, previously only 'text' and 'value' were being passed to
<Dropdown.Item>. This makes it so the entire object is passed as props.cc #416