-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Dropdown): update search prop typing #4014
Conversation
💖 Thanks for opening this pull request! 💖 Here is a list of things that will help get it across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov Report
@@ Coverage Diff @@
## master #4014 +/- ##
=======================================
Coverage 99.84% 99.84%
=======================================
Files 185 185
Lines 3251 3251
=======================================
Hits 3246 3246
Misses 5 5 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated PR title to auto close the issue, https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue
Thanks 👍
I didn't know that was a thing - thanks! |
Thank you for the fix 🙏🏼 |
I will ask @levithomason to do it today. |
Fixes #4013. Reverted the Dropdown.search prop typing to the previous version as per #4013