Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown): update search prop typing #4014

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

charliematters
Copy link
Contributor

@charliematters charliematters commented Jul 31, 2020

Fixes #4013. Reverted the Dropdown.search prop typing to the previous version as per #4013

@welcome
Copy link

welcome bot commented Jul 31, 2020

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2020

Codecov Report

Merging #4014 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4014   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         185      185           
  Lines        3251     3251           
=======================================
  Hits         3246     3246           
  Misses          5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 125fda7...f85b81e. Read the comment docs.

Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@charliematters
Copy link
Contributor Author

I didn't know that was a thing - thanks!

@layershifter layershifter merged commit f138b15 into Semantic-Org:master Jul 31, 2020
@welcome
Copy link

welcome bot commented Jul 31, 2020

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@felixmosh
Copy link
Contributor

Thank you for the fix 🙏🏼
@layershifter when this fix will be published?

@layershifter
Copy link
Member

@layershifter when this fix will be published?

I will ask @levithomason to do it today.

@layershifter
Copy link
Member

@felixmosh published in 1.1.1: https://github.com/Semantic-Org/Semantic-UI-React/releases/tag/v1.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown: search prop has invalid typings
4 participants