Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(SearchExampleStandard): use React hooks #3794

Merged
merged 6 commits into from
Aug 4, 2020

Conversation

rpatelcode
Copy link
Contributor

Converted into Functional functional component

Converted into Functional functional component
@welcome
Copy link

welcome bot commented Sep 26, 2019

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@rpatelcode rpatelcode changed the title docs(SearchExampleStandard): Converted into Functional functional component docs(SearchExampleStandard): Converted into functional component Sep 26, 2019
@vercel
Copy link

vercel bot commented Aug 4, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

@vercel vercel bot temporarily deployed to Preview August 4, 2020 08:11 Inactive
@vercel vercel bot temporarily deployed to Preview August 4, 2020 08:11 Inactive
@layershifter layershifter changed the title docs(SearchExampleStandard): Converted into functional component docs(SearchExampleStandard): use React hooks Aug 4, 2020
@vercel vercel bot temporarily deployed to Preview August 4, 2020 08:14 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2020

Codecov Report

Merging #3794 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3794   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         185      185           
  Lines        3251     3251           
=======================================
  Hits         3246     3246           
  Misses          5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91c9040...063efe6. Read the comment docs.

Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, I did few changes. It will be great if we can do update remaining examples...

@layershifter layershifter merged commit 0f9c691 into Semantic-Org:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants