Dropdown: resize search on change #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 92.66% (diff: 100%)@@ master #371 diff @@
==========================================
Files 63 63
Lines 811 818 +7
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 751 758 +7
Misses 60 60
Partials 0 0
|
| this.setState({ | ||
| selectedIndex: 0, | ||
| searchQuery: newQuery, | ||
| searchWidth, |
There was a problem hiding this comment.
If there is no newQuery (search text) then this value will be undefined so the width removed instead of set to 0.
31bba69 to
df75f73
Compare
|
👻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #370. The search input has a short fixed width that truncates the value. This PR resizes the Dropdown search input on change. SUI css allows for a
span.sizerchild to measure the search input width. We use this to perform the same resizing as the SUI Dropdown module, but in vanilla JS.