Temporarily bundle jQuery and SUI JS #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "lodash": "^4.6.1" | ||
| "jquery": "^3.1.0", | ||
| "lodash": "^4.6.1", | ||
| "semantic-ui-css": "^2.2.1" |
There was a problem hiding this comment.
I'll be so glad the day I delete these two lines.
d2ab76e to
2779b7e
Compare
| $: 'jquery', | ||
| jQuery: 'jquery', | ||
| 'window.jQuery': 'jquery', | ||
| }), |
There was a problem hiding this comment.
We don't expose jQuery on the window up front. We attach it to the window ourselves after require()ing it. We do this so we can throw an error if the user has already loaded it on the window before we load.
4a655cb to
0c0f018
Compare
| @@ -160,7 +155,8 @@ webpackConfig.module.loaders = [{ | |||
| // ---------------------------------------- | |||
| // For faster builds in dev, rely on prebuilt libraries | |||
| // Local modules can still be enabled (ie for offline development) | |||
| if (argv.localModules) { | |||
| // in TEST we need local modules because karma uses a different index.html (no CDNs) | |||
| if (__TEST__ || argv.localModules) { | |||
There was a problem hiding this comment.
In tests we use local modules, there are no CDNs.
0c0f018 to
8289447
Compare
jhchill666
pushed a commit
to jhchill666/stardust
that referenced
this pull request
Jul 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #326. This PR address the issue of two copies of jQuery being loaded. One on the the window via script tag, and another via the webpack bundle.
To simplify things for users for now, we simply bundle jQuery and SUI JS with Stardust. This is only temporary as we are moving quickly to remove jQuery in #247.