Add CONTRIBUTING guidelines #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 88.32%@@ master #317 diff @@
==========================================
Files 62 62
Lines 821 822 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 725 726 +1
Misses 96 96
Partials 0 0
|
99be9a4 to
128a8a9
Compare
|
|
||
| ### _meta | ||
|
|
||
| Every component has a static property called `_meta`. This object defines the component. The values here are used in `propTypes`, generated documentation, generated test cases, and some utilities. |
There was a problem hiding this comment.
Oh gross, the markdown is messed up in the diff from the _meta. Looks fine in the real renderer, though.
There was a problem hiding this comment.
Yea, never much luck with big diffs of markdown.
|
Mostly grammar fixes, 👻 other than that though, looks good. |
|
Also, not sure if you want to include it, but since we abide by them.... https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit |
128a8a9 to
d6d9215
Compare
93f7a50 to
c3d83d9
Compare
|
Added commit message format guidelines. |
eca3137 to
574255e
Compare
574255e to
fab8de5
Compare
4 tasks
jhchill666
pushed a commit
to jhchill666/stardust
that referenced
this pull request
Jul 5, 2016
* fix(webpack): remove cruft * fix(Label): fix doc block grammar * feat(package): add markdown toc with doctoc * docs(contributing): add contributing doc * refactor(readme): remove all dev info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #314. This PR adds contributing guidelines and updates the README to account for those. Best to view the rendered versions:
CONTRIBUTING.md
README.md updated