Fix dropdown set value and error #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| /* eslint-disable no-console */ | ||
| if (nextProps.multiple && !isNextValueArray) { | ||
| if (hasValue && nextProps.multiple && !isNextValueArray) { |
There was a problem hiding this comment.
We should not throw these dev errors regarding value unless there is actually a value.
|
👻 |
| this.onChange(e, _.union(this.state.value, [value])) | ||
| const newValue = _.union(this.state.value, [value]) | ||
| this.setValue(newValue) | ||
| this.onChange(e, newValue) |
There was a problem hiding this comment.
This should arguably be handled by trySetState, but we're handling in the component for now.
jhchill666
pushed a commit
to jhchill666/stardust
that referenced
this pull request
Jul 5, 2016
* fix(Dropdown): only throw val prop error if val prop * fix(Dropdown): setValue to correct type on click/enter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.