Fix input action examples #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const isLabel = _.isString(child.props.className) && !!child.props.className.match(/ui.*label$/) | ||
| const childIsAction = !isLabel && isButton || isDropdown | ||
| const isAction = _.includes(['Button', 'Dropdown', 'Select'], child.type._meta.name) | ||
| const isLabel = child.type._meta.name === 'Label' |
There was a problem hiding this comment.
This component is being updated in #281, however, this change was made now so the docs aren't broken. The _meta is used to identify the component as the function names are mangled in production.
Current coverage is 88.24%
|
| @@ -10,7 +10,7 @@ export default class InputActionExample extends Component { | |||
| ] | |||
| return ( | |||
| <Input className='left icon action' icon='search' placeholder='Search...'> | |||
| <Dropdown compact selection options={options} defaultValue='articles' /> | |||
| <Select compact options={options} defaultValue='articles' /> | |||
There was a problem hiding this comment.
Use select components where possible.
jhchill666
pushed a commit
to jhchill666/stardust
that referenced
this pull request
Jul 5, 2016
* fix(Input): use _meta to identify action children * refactor(docs): use Select where possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the broken input action examples on the doc site by avoiding references to mangled component function names:
Docs
This PR