fix(Popup): default open position #3029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3029 +/- ##
==========================================
+ Coverage 99.89% 99.89% +<.01%
==========================================
Files 170 170
Lines 2809 2818 +9
==========================================
+ Hits 2806 2815 +9
Misses 3 3
Continue to review full report at Codecov.
|
|
@levithomason Seems that it's really an bug in ReactDOM, it tried to debug this. The issue comes from the The simpliest and stupid solution, disable html preview for specific examples. However, I'm not sure, that it's the best solution. |
…to fix/pop-open-position
…to fix/pop-open-position # Conflicts: # package.json # yarn.lock
….com/Semantic-Org/Semantic-UI-React into fix/pop-open-position # Conflicts: # docs/src/components/ComponentDoc/ComponentControls/ComponentControls.js # docs/src/components/ComponentDoc/ComponentExample/ComponentExample.js
….com/Semantic-Org/Semantic-UI-React into fix/pop-open-position # Conflicts: # yarn.lock
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2991.
This PR was branched from #3020 to perform some cleanup and updates since the original PR was from a fork's master and couldn't be updated.
I've also added a "Default Open" example to the docs for this use case.
It seems there is a bug with the use of
ReactDOM.createPortalinInnerPortal. When rendering a Portal withopenset to true on first render, an infinite loop is entered upon rendering theInnerPortal. IfcreatePortalis bypassed, there is no infinite loop. I do not yet know why this is :/