Fix debug dependency #300
Merged
Fix debug dependency #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 88.07%
|
|
🐙 |
|
👻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #296. This PR moves
debugfrom devDeps to deps.Because we use
debugin dev and other apps, we have the module. We also use webpack with dead code elimination for production builds, which strips therequire('debug')call on production.However, when we build Stardust for consumption, we only parse it with babel as it is up to the user to then webpack it into their own app. This means some users can be missing the
debugmodule and not webpack with production + dead code elimination and therefore get the error in the linked issue.I don't like adding more dependencies to the published dist, but in this case it is the shortest path to a solution.