add modal and confirmationmodal components to stardust #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0dfaed3 to
d77a0d3
Compare
| }; | ||
|
|
||
| state = { | ||
| message: 'Remove this item from the list?', |
There was a problem hiding this comment.
This may not always be used for deleting list items. Let's find a fully generic message or have no default.
c78ae07 to
021133d
Compare
| let renderedGridClasses = render(<Modal className={classes} />) | ||
| .findClass('sd-modal') | ||
| .getDOMNode() | ||
| .getAttribute('class'); |
There was a problem hiding this comment.
remove test for DOM class attributes, as that is testing the React renderer, not our actual component :)
…nologyAdvice/stardust into feature/add-modal-plus-confirmation
|
🚢 |
athurman
added a commit
that referenced
this pull request
Oct 3, 2015
…nfirmation add modal and confirmationmodal components to stardust
This was referenced Oct 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to this PR for review: https://github.com/TechnologyAdvice/unity/pull/160