Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label allow bool corner prop #294

Merged
merged 2 commits into from
Jun 27, 2016
Merged

Label allow bool corner prop #294

merged 2 commits into from
Jun 27, 2016

Conversation

levithomason
Copy link
Member

@levithomason levithomason commented Jun 27, 2016 •
edited
Loading

Fixes #292. These two are forms of markup are synonymous and both supported in SUI:

<div class="ui corner label"></div>
<div class="ui right corner label"></div>

This PR allows <Label corner /> where we previously required corner='left|right'.

@levithomason levithomason force-pushed the feature/label-corner-bool branch from 6384408 to 883b2bb Compare June 27, 2016 06:59
@codecov-io
Copy link

Current coverage is 88.07%

No coverage report found for master at 179b887.

Powered by Codecov. Last updated by 179b887...883b2bb

@levithomason levithomason merged commit f8e90d9 into master Jun 27, 2016
@levithomason levithomason deleted the feature/label-corner-bool branch June 27, 2016 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@levithomason @codecov-io